Skip to content

[WebNN] Support AveragePool with count_include_pad == 1 #24465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2025
Merged

[WebNN] Support AveragePool with count_include_pad == 1 #24465

merged 1 commit into from
Apr 20, 2025

Conversation

Honry
Copy link
Contributor

@Honry Honry commented Apr 18, 2025

Description

WebNN doesn't support AveragePool with count_include_pad == 1.

Motivation and Context

Support it by adding a pad and calling averagePool2D with pads as 0's.

@Honry
[WebNN] Support AveragePool with count_include_pad == 1
247514d 
WebNN doesn't support AveragePool with count_include_pad == 1,
but it can be emulated by inserting a pad operator.
@Honry
Copy link
Contributor Author

Honry commented Apr 18, 2025

@fdwr, @guschmue, PTAL, thanks!

@fdwr
Copy link
Contributor

fdwr commented Apr 19, 2025

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline,Windows GPU WebGPU CI Pipeline,Windows OpenVINO CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Apr 19, 2025

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Apr 19, 2025

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI

@fdwr
Copy link
Contributor

fdwr commented Apr 19, 2025

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

fdwr
fdwr approved these changes Apr 19, 2025
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr
Copy link
Contributor

fdwr commented Apr 20, 2025

Completing despite the 5 test failures above which keep failing in this PR and others, as they are unrelated (and not required either):

  • Big Models
  • Big Models (Build_Onnxruntime_Cuda Linux_Build)
  • Big Models (Llama2_7B_ONNX Llama2_7B_ONNX)
  • Linux CPU Minimal Build E2E CI Pipeline
  • onnxruntime-binary-size-checks-ci-pipeline

e.g.

#2 [internal] load metadata for onnxruntimebuildcache.azurecr.io/internal/azureml/onnxruntime/build/cpu_x64_ubi8_gcc14_dotnet:20250124.1
#2 ERROR: failed to authorize: failed to fetch anonymous token

https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1669389&view=logs&j=c0b799d6-18b6-56f3-32a9-d967e9a2810f&t=9c614e8a-74a4-58bb-cc51-8d2510ee34f2&l=19

@fdwr fdwr merged commit 9c6351f into microsoft:main Apr 20, 2025
71 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdwr fdwr fdwr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Honry @fdwr